fix: prevent endless reconciliation when unsetting connection limit in roles #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsilvela
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
Closed
3 tasks
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
|
/test feature_type=smoke |
|
@jsilvela, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/7918449018 |
litaocdl
approved these changes
Feb 19, 2024
|
E2E running on EDB fork https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/8246050228 |
mnencia
approved these changes
Mar 12, 2024
|
/ok-to-merge E2E green |
…n a role Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…n roles (#3832) In the managed roles reconciler, the connection limit was only explicitly set if it was not default (-1). This does not work as intended if the managed role tries to unset a connection limit that was not previously -1. In this case the instance manager gets into indefinite reconciliation: - it recognizes the value in the DB is not the same as the manifest - since the manifest has the default connection limit, it makes no update This patch always explicitly sets the connection limit when updating a role. Closes #3831 Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> (cherry picked from commit 4d8516b)
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…n roles (#3832) In the managed roles reconciler, the connection limit was only explicitly set if it was not default (-1). This does not work as intended if the managed role tries to unset a connection limit that was not previously -1. In this case the instance manager gets into indefinite reconciliation: - it recognizes the value in the DB is not the same as the manifest - since the manifest has the default connection limit, it makes no update This patch always explicitly sets the connection limit when updating a role. Closes #3831 Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> (cherry picked from commit 4d8516b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the managed roles reconciler, the connection limit was only explicitly set
if it was not default (-1). This does not work as intended if the managed role
is trying to unset a connection limit that was not previously -1.
In this case the instance manager gets into indefinite reconciliation:
This patch always explicitly sets the connection limit when updating a role.
Closes #3831