fix: cluster phase change should not interrupt the hibernation processing #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanniHu1996
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco,
sxd and
armru
as code owners
github-actions
bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
YanniHu1996
force-pushed
the
dev/3965
branch
3 times, most recently
from
6cea92b
to
31d86cf
Compare
YanniHu1996
force-pushed
the
dev/3965
branch
2 times, most recently
from
93a045e
to
f8e906c
Compare
litaocdl
force-pushed
the
dev/3965
branch
2 times, most recently
from
fe761c6
to
3eba6b3
Compare
litaocdl
approved these changes
Mar 13, 2024
litaocdl
changed the title
litaocdl
changed the title
armru
force-pushed
the
dev/3965
branch
2 times, most recently
from
2a555db
to
fe96fd8
Compare
armru
approved these changes
Mar 13, 2024
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
|
/ok-to-merge |
litaocdl
added a commit
that referenced
this pull request
Mar 13, 2024
This patch fix a corner case that during hibernation, instance pod has been deleted but cluster status still have hibernation condition `k8s.enterprisedb.io/hibernation` set to state=false. Also in this patch, we enfored the hibernation annotation `k8s.enterprisedb.io/hibernation` can only accept `on` and `off` value in webhook. closes #3965 Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
litaocdl
added a commit
that referenced
this pull request
Mar 13, 2024
This patch fix a corner case that during hibernation, instance pod has been deleted but cluster status still have hibernation condition `k8s.enterprisedb.io/hibernation` set to state=false. Also in this patch, we enfored the hibernation annotation `k8s.enterprisedb.io/hibernation` can only accept `on` and `off` value in webhook. closes #3965 Signed-off-by: YanniHu1996 <yantian.hu@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fix a corner case that during hibernation, instance pod has
been deleted but cluster status still have hibernation condition
k8s.enterprisedb.io/hibernationset to state=false. Also in this patch,we enfored the hibernation annotation
k8s.enterprisedb.io/hibernationcan only accept
onandoffvalue in webhook.closes #3965