-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable configuration of wal_level
#4020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armru
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
March 6, 2024 11:50
github-actions
bot
added
backport-requested ◀️
This pull request should be backported to all supported releases
release-1.21
release-1.22
labels
Mar 6, 2024
❗ By default, the pull request is configured to backport to all release branches.
|
armru
changed the title
chore: calculate
feat: allow the configuration of the wal_level parameter
Mar 7, 2024
archive_mode
and wal_level
values
armru
force-pushed
the
dev/3746
branch
3 times, most recently
from
March 7, 2024 11:53
2b7dc2b
to
e66eef4
Compare
gbartolini
reviewed
Mar 7, 2024
leonardoce
reviewed
Mar 7, 2024
/test limit=local |
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8188072212 |
armru
force-pushed
the
dev/3746
branch
2 times, most recently
from
March 7, 2024 16:27
f6a75be
to
685b5fa
Compare
gbartolini
reviewed
Mar 7, 2024
gbartolini
changed the title
feat: allow the configuration of the wal_level parameter
feat: enable configuration of Mar 8, 2024
wal_level
gbartolini
approved these changes
Mar 8, 2024
This patch allows the user to customize the `wal_level` parameter. Partially Closes #3746 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
This patch enables users to customize the `wal_level` GUC in PostgreSQL, while enforcing a minimum value based on the cluster specification, such as number of instances or `archive_mode` settings. At the moment, the only allowed values are `replica` and `logical` as it is not currently possible to disable WAL archiving. Closes #3746 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> (cherry picked from commit 8bfe05a)
cnpg-bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
This patch enables users to customize the `wal_level` GUC in PostgreSQL, while enforcing a minimum value based on the cluster specification, such as number of instances or `archive_mode` settings. At the moment, the only allowed values are `replica` and `logical` as it is not currently possible to disable WAL archiving. Closes #3746 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> (cherry picked from commit 8bfe05a)
gbartolini
added a commit
that referenced
this pull request
Mar 8, 2024
Fix a regression introduced by me at the last minute while changing a string in PR #4020. Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
gbartolini
added a commit
that referenced
this pull request
Mar 8, 2024
Fix a regression introduced by me at the last minute while changing a string in PR #4020. Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-requested ◀️
This pull request should be backported to all supported releases
release-1.21
release-1.22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables users to customize the
wal_level
GUC in PostgreSQL, while enforcing a minimum value based on the cluster specification, such as number of instances orarchive_mode
settings.At the moment, the only allowed values are
replica
andlogical
as it is not currently possible to disable WAL archiving.Closes #3746