Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable configuration of wal_level #4020

Merged
merged 11 commits into from
Mar 8, 2024
Merged

feat: enable configuration of wal_level #4020

merged 11 commits into from
Mar 8, 2024

Conversation

armru
Copy link
Member

@armru armru commented Mar 6, 2024

This patch enables users to customize the wal_level GUC in PostgreSQL, while enforcing a minimum value based on the cluster specification, such as number of instances or archive_mode settings.

At the moment, the only allowed values are replica and logical as it is not currently possible to disable WAL archiving.

Closes #3746

@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.21 release-1.22 labels Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@armru armru added the risk 💥 Risk/Compliance label Mar 6, 2024
@armru armru changed the title chore: calculate archive_mode and wal_level values feat: allow the configuration of the wal_level parameter Mar 7, 2024
@armru armru force-pushed the dev/3746 branch 3 times, most recently from 2b7dc2b to e66eef4 Compare March 7, 2024 11:53
@armru
Copy link
Member Author

armru commented Mar 7, 2024

/test limit=local

@armru armru removed the risk 💥 Risk/Compliance label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/8188072212

@gbartolini gbartolini changed the title feat: allow the configuration of the wal_level parameter feat: enable configuration of wal_level Mar 8, 2024
armru and others added 10 commits March 8, 2024 14:12
This patch allows the user to customize the `wal_level` parameter.

Partially Closes #3746

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
@gbartolini gbartolini merged commit 8bfe05a into main Mar 8, 2024
13 of 14 checks passed
@gbartolini gbartolini deleted the dev/3746 branch March 8, 2024 13:19
cnpg-bot pushed a commit that referenced this pull request Mar 8, 2024
This patch enables users to customize the `wal_level` GUC in PostgreSQL,
while enforcing a minimum value based on the cluster specification, such
as number of instances or `archive_mode` settings.

At the moment, the only allowed values are `replica` and `logical` as it
is not currently possible to disable WAL archiving.

Closes #3746

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
(cherry picked from commit 8bfe05a)
cnpg-bot pushed a commit that referenced this pull request Mar 8, 2024
This patch enables users to customize the `wal_level` GUC in PostgreSQL,
while enforcing a minimum value based on the cluster specification, such
as number of instances or `archive_mode` settings.

At the moment, the only allowed values are `replica` and `logical` as it
is not currently possible to disable WAL archiving.

Closes #3746

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
(cherry picked from commit 8bfe05a)
gbartolini added a commit that referenced this pull request Mar 8, 2024
Fix a regression introduced by me at the last minute while changing
a string in PR #4020.

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
gbartolini added a commit that referenced this pull request Mar 8, 2024
Fix a regression introduced by me at the last minute while changing a
string in PR #4020.

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
cnpg-bot pushed a commit that referenced this pull request Mar 8, 2024
Fix a regression introduced by me at the last minute while changing a
string in PR #4020.

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
(cherry picked from commit dc70b35)
cnpg-bot pushed a commit that referenced this pull request Mar 8, 2024
Fix a regression introduced by me at the last minute while changing a
string in PR #4020.

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
(cherry picked from commit dc70b35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases release-1.21 release-1.22
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Enable configuration of wal_level
3 participants