Long network device names

[nwaples]

We have network interfaces that are reaching the maximum device name length.

(pktdev_allocate : 84) ERR: Ethernet device name is too long
(init_lport : 209) ERR: pktdev_allocate(enp24s0f0np0:10, enp24s0f0np0) failed
(pmd_af_xdp_probe : 248) ERR: Failed to init lport
(pktdev_port_setup : 50) ERR: driver probe(enp24s0f0np0:net_af_xdp) failed
2023/11/01 02:32:01 cndp init failed: pktdev_port_setup() failed for lport enp24s0f0np0:10

and

cndp init failed: pktdev_port_setup() failed for lport enp152s0f0np0:0

Is it possible to increase the PKTDEV_NAME_MAX_LEN value from 16?

[KeithWiles]

I do not see why increasing it to 24 or 32 would be a problem. Will look into it, but it may increase the size of some structures to cover another cacheline as I was thinking 32 would be good.

[KeithWiles]

I did not spot any problems increasing the size, but please verify it thanks.

Original size:

CNDP-cli:/> info size

sizeof(struct pktmbuf_s)         :   64
            CNE_PKTMBUF_HEADROOM :  192
  		Default size 2048 dataroom size 1,792
sizeof(struct cnet_metadata)     :   64
               unused space in metadata structure 24
sizeof(struct in_caddr)          :   20
sizeof(struct cnet)              :  192
sizeof(struct pcb_entry)         :  128
sizeof(struct pcb_key)           :   40
sizeof(struct msghdr)            :   56
sizeof(struct sockaddr)          :   16
sizeof(struct sockaddr_storage)  :  128
sizeof(struct stk_s)             :  352 *     2(netifs) = 704
sizeof(struct netif)             :  640 *     8(netifs) = 5120
sizeof(struct drv_entry)         :  128 *     4(netifs) = 512
sizeof(struct rt4_entry)         :   64 *  1024(netifs) = 65536
sizeof(struct rt6_entry)         :  128 *     0(netifs) = 0
sizeof(struct arp_entry)         :   16 *  1024(netifs) = 16384
sizeof(struct nd6_cache_entry)   :   64 *     0(netifs) = 0
sizeof(struct ipv4_entry)        :  192
sizeof(struct ipv6_entry)        :  192

  Total memory used 88832 bytes

sizeof(struct protosw_entry)     :   40
sizeof(struct seg_entry)         :  120
                 sizeof(__m128i) :   16
                 sizeof(__m256i) :   32
sizeof(struct vec_hdr)           :   16

New sizes:

CNDP-cli:/> info size

sizeof(struct pktmbuf_s)         :   64
            CNE_PKTMBUF_HEADROOM :  192
  		Default size 2048 dataroom size 1,792
sizeof(struct cnet_metadata)     :   64
               unused space in metadata structure 24
sizeof(struct in_caddr)          :   20
sizeof(struct cnet)              :  192
sizeof(struct pcb_entry)         :  128
sizeof(struct pcb_key)           :   40
sizeof(struct msghdr)            :   56
sizeof(struct sockaddr)          :   16
sizeof(struct sockaddr_storage)  :  128
sizeof(struct stk_s)             :  352 *     2(netifs) = 704
sizeof(struct netif)             :  640 *     8(netifs) = 5120
sizeof(struct drv_entry)         :  128 *     4(netifs) = 512
sizeof(struct rt4_entry)         :   64 *  1024(netifs) = 65536
sizeof(struct rt6_entry)         :  128 *     0(netifs) = 0
sizeof(struct arp_entry)         :   16 *  1024(netifs) = 16384
sizeof(struct nd6_cache_entry)   :   64 *     0(netifs) = 0
sizeof(struct ipv4_entry)        :  192
sizeof(struct ipv6_entry)        :  192

  Total memory used 88832 bytes

sizeof(struct protosw_entry)     :   40
sizeof(struct seg_entry)         :  120
                 sizeof(__m128i) :   16
                 sizeof(__m256i) :   32
sizeof(struct vec_hdr)           :   16

[KeithWiles]

Please checkout the latest PR and let me know if it fixes the problem.

[nwaples]

Yep it fixes the problem.
Thanks