Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for checking and comparing value in Last-Modified Header #414

Closed
syd20 opened this issue Jun 20, 2023 · 3 comments · Fixed by #493
Closed

Support for checking and comparing value in Last-Modified Header #414

syd20 opened this issue Jun 20, 2023 · 3 comments · Fixed by #493
Labels
enhancement New feature or request

Comments

@syd20
Copy link

syd20 commented Jun 20, 2023

Support for checking and comparing Last-Modified Header

I would like to see an additional validation based on Last Modified Header where I compare the value against the input value. It should return a successful validation if the difference is within the specified input duration else a failed validation. Based on documentation, success_header option in validator checks for specific time stamp and not the difference between current time and last modified time

@manugarg
Copy link
Contributor

manugarg commented Sep 3, 2023

@syd20 Can you please also add a use case that would require such a validation?

@syd20
Copy link
Author

syd20 commented Sep 3, 2023

I need to configure probes where I look up the value in Last Modified header, and need to check if the Last Modified time is greater than x seconds/ minutes as compared to the current time. This is solely for verifying if the content had been updated or is stale. The duration difference ( in seconds or minutes) would be specified in configuration file and could vary for different checks. Check is treated a failure if the Last Modified value exceeds the duration specified.

@syd20
Copy link
Author

syd20 commented Sep 8, 2023

Thanx for the rolling out this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants