Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP probe doesn't change TLS ServerName for discovered resources #417

Closed
manugarg opened this issue Jun 21, 2023 Discussed in #412 · 1 comment · Fixed by #420
Closed

HTTP probe doesn't change TLS ServerName for discovered resources #417

manugarg opened this issue Jun 21, 2023 Discussed in #412 · 1 comment · Fixed by #420
Labels
bug Something isn't working
Milestone
v0.12.8

Comments

@manugarg
Copy link
Contributor

manugarg commented Jun 21, 2023 •
edited

We use only resolve_first option to decide if we should change TLS config's server name. That's not sufficient. Now we resolve targets first for all discovered resources. We should fix this behavior.

Discussed in #412
@manugarg manugarg added the bug Something isn't working label Jul 12, 2023
@manugarg manugarg added this to the v0.12.8 milestone Jul 12, 2023
@manugarg manugarg mentioned this issue Jul 12, 2023
Merged
@manugarg
Copy link
Contributor Author

Also added tests to detect this/similar issue next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.12.8
Development

Successfully merging a pull request may close this issue.

[probes.http] Fix how we determine whether to change TLS config servername. cloudprober/cloudprober
1 participant
@manugarg