Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(providers-sync): Improve error message #1006

Merged
merged 2 commits into from Jun 26, 2022
Merged

fix(providers-sync): Improve error message #1006

merged 2 commits into from Jun 26, 2022

Conversation

erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Jun 26, 2022 •
edited

Summary

Related to https://github.com/cloudquery/docs/issues/216. Quick fix to improve messaging until we improve the docs

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@erezrokah erezrokah requested a review from a team as a code owner June 26, 2022 08:25
@erezrokah erezrokah requested review from spangenberg and removed request for a team June 26, 2022 08:25
@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Jun 26, 2022
@kodiakhq kodiakhq bot merged commit a38b443 into cloudquery:main Jun 26, 2022
@cq-bot cq-bot mentioned this pull request Jun 26, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 26, 2022
@cq-bot
chore(main): Release v0.28.1 (#1007)
32259f5 
🤖 I have created a release *beep* *boop*
---


## [0.28.1](v0.28.0...v0.28.1) (2022-06-26)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.12.3 ([#1008](#1008)) ([2eb7ecf](2eb7ecf))
* Policy download test ([#1009](#1009)) ([a3312e9](a3312e9))
* **providers-sync:** Improve error message ([#1006](#1006)) ([a38b443](a38b443))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@erezrokah erezrokah deleted the fix/improve_error_message branch August 9, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roneli roneli roneli approved these changes

@spangenberg spangenberg Awaiting requested review from spangenberg spangenberg was automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
automerge Automatically merge once required checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erezrokah @roneli