fix: Update 'policy run' help message #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimonp21
requested review from
hermanschaaf and
erezrokah
and removed request for
a team
erezrokah
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Thanks for the PR @shimonp21 👍
I added a few comments, all non blocking in my opinion:
- I think it's common to use
<param>to denote a value supplied by the user - I think we should either reference the Hub or GitHub, but not both
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
erezrokah
approved these changes
Jun 30, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 3, 2022
🤖 I have created a release *beep* *boop* --- ## [0.30.3](v0.30.2...v0.30.3) (2022-07-03) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.13.1 ([#1056](#1056)) ([f216d90](f216d90)) * Update 'policy run' help message ([#1037](#1037)) ([2235e82](2235e82)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
added a commit
that referenced
this pull request
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)