Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Add code of conduct contact details & commit message guidelines to CONTRIBUTING.md #1043

Merged

Conversation

hermanschaaf
Copy link
Member

Summary

  • Fix contact details in Code of Conduct section
  • Add section about commit messages to CONTRIBUTING.md

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@hermanschaaf hermanschaaf requested a review from a team as a code owner June 29, 2022 14:18
@hermanschaaf hermanschaaf requested review from bbernays and erezrokah and removed request for a team June 29, 2022 14:18
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hermanschaaf, very helpful 🚀

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
hermanschaaf and others added 3 commits June 29, 2022 15:24
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
…aaf/cloudquery into update-contribution-guidelines
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hermanschaaf hermanschaaf merged commit b304bbc into cloudquery:main Jun 29, 2022
kodiakhq bot pushed a commit that referenced this pull request Jun 30, 2022
🤖 I have created a release *beep* *boop*
---


## [0.30.1](v0.30.0...v0.30.1) (2022-06-30)


### Features

* Track config format ([#1040](#1040)) ([3a3ad17](3a3ad17))


### Bug Fixes

* Doc command to generate id meta without space ([#1046](#1046)) ([be12ebf](be12ebf))
* **docs:** Add code of conduct contact details & commit message guidelines to CONTRIBUTING.md ([#1043](#1043)) ([b304bbc](b304bbc))
* Support env var substitution in YAML config ([#1041](#1041)) ([3bc8014](3bc8014))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants