-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for ACL configuration in S3 Destination #17953
Conversation
@caiorcferreira - Overall this looks good, would you mind updating it so that the spacing for the files that you updated isn't changed from tabs/spaces? This will help reduce the size of the change |
@bbernays just fixed the spacing! |
Hi @caiorcferreira - Because the tests need access to our AWS account to test the destination against a real bucket. I am working on copying your branch to my own branch then will run the tests and once those tests pass, we will force merge your pr |
🤖 I have created a release *beep* *boop* --- ## [7.1.0](plugins-destination-s3-v7.0.1...plugins-destination-s3-v7.1.0) (2024-05-15) ### Features * Add support for ACL configuration in S3 Destination ([#17953](#17953)) ([5dbf8da](5dbf8da)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@caiorcferreira - Thank you for this contribution, we have kicked off the release of |
Summary
This pull request adds ACL configuration support to the S3 destination plugin. This feature allows to specify the Access Control List (ACL) policy in the S3 destination plugin.
Problem Addressed
Before this PR, users could not specify an ACL policy when putting an object in an S3 bucket using the S3 destination plugin. This limitation could prevent users from sending data across AWS accounts.