Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws): Support AWS Account Contacts #4734

Merged
merged 7 commits into from
Nov 17, 2022
Merged

feat(aws): Support AWS Account Contacts #4734

merged 7 commits into from
Nov 17, 2022

Conversation

bbernays
Copy link
Collaborator

Summary

@cq-bot cq-bot added the aws label Nov 16, 2022
@bbernays bbernays linked an issue Nov 16, 2022 that may be closed by this pull request
Support for AWS Accounts, specifically Contact Information and Alternate Contacts #2475
Closed
hermanschaaf
hermanschaaf requested changes Nov 17, 2022
View reviewed changes
Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the descriptions that need to be updated I think

plugins/source/aws/codegen/recipes/account.go Outdated Show resolved Hide resolved
plugins/source/aws/codegen/recipes/account.go Outdated
{
SubService: "contacts",
Struct: &types.ContactInformation{},
Description: "https://docs.aws.amazon.com/acm/latest/APIReference/API_CertificateDetail.html",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@bbernays bbernays added the automerge Automatically merge once required checks pass label Nov 17, 2022
@kodiakhq kodiakhq bot merged commit bdf3867 into cloudquery:main Nov 17, 2022
@bbernays bbernays deleted the aws-account branch November 17, 2022 16:22
@cq-bot cq-bot mentioned this pull request Nov 17, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Nov 18, 2022
@cq-bot
chore(main): Release plugins-source-aws v7.1.0 (#4733)
6c1bbe9 
🤖 I have created a release *beep* *boop*
---


## [7.1.0](plugins-source-aws-v7.0.1...plugins-source-aws-v7.1.0) (2022-11-18)


### Features

* **aws:** Add Support For Config Rules and Compliance ([#4730](#4730)) ([100f4ba](100f4ba))
* **aws:** Support AWS Account Contacts ([#4734](#4734)) ([bdf3867](bdf3867))


### Bug Fixes

* **aws:** Cloudfront control fails for specific configuration ([#4735](#4735)) ([7507bae](7507bae))
* **aws:** Remove ARN helper usage ([#4714](#4714)) ([dde430f](dde430f)), closes [#4689](#4689)
* **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.1 ([#4736](#4736)) ([db70d2a](db70d2a))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.2 ([#4775](#4775)) ([136fb42](136fb42))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/credentials to v1.13.2 ([#4737](#4737)) ([2b2433d](2b2433d))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.40 ([#4738](#4738)) ([69b01cc](69b01cc))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.41 ([#4776](#4776)) ([d0b2bae](d0b2bae))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/accessanalyzer to v1.17.2 ([#4739](#4739)) ([3c85f78](3c85f78))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/acm to v1.16.2 ([#4740](#4740)) ([e2a734d](e2a734d))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigateway to v1.15.24 ([#4741](#4741)) ([6bec735](6bec735))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/apigatewayv2 to v1.12.22 ([#4742](#4742)) ([56bebb8](56bebb8))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/applicationautoscaling to v1.15.22 ([#4756](#4756)) ([ba77807](ba77807))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/appsync to v1.16.0 ([#4788](#4788)) ([21d3b1d](21d3b1d))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/autoscaling to v1.24.2 ([#4743](#4743)) ([c366ea3](c366ea3))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudformation to v1.24.0 ([#4789](#4789)) ([3616ed2](3616ed2))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudtrail to v1.20.2 ([#4744](#4744)) ([c0c32d3](c0c32d3))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatch to v1.21.10 ([#4745](#4745)) ([f1c7a99](f1c7a99))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v1.16.3 ([#4746](#4746)) ([1d020a0](1d020a0))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/configservice to v1.27.4 ([#4747](#4747)) ([ec6aed0](ec6aed0))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/databasemigrationservice to v1.21.16 ([#4748](#4748)) ([a04a343](a04a343))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/databasemigrationservice to v1.22.0 ([#4790](#4790)) ([cffe44a](cffe44a))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/directconnect to v1.17.22 ([#4749](#4749)) ([d98c79e](d98c79e))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/docdb to v1.19.15 ([#4757](#4757)) ([d058d34](d058d34))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/dynamodb to v1.17.5 ([#4750](#4750)) ([9b0e200](9b0e200))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ec2 to v1.70.1 ([#4751](#4751)) ([6b75a34](6b75a34))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ec2 to v1.71.0 ([#4791](#4791)) ([58368df](58368df))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ecr to v1.17.22 ([#4752](#4752)) ([b769ff7](b769ff7))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ecs to v1.19.1 ([#4753](#4753)) ([95b3bc4](95b3bc4))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/eks to v1.23.0 ([#4792](#4792)) ([a7e546b](a7e546b))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticache to v1.24.0 ([#4793](#4793)) ([c392bfb](c392bfb))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing to v1.14.22 ([#4758](#4758)) ([1a385c3](1a385c3))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 to v1.18.24 ([#4759](#4759)) ([236ac56](236ac56))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 to v1.18.25 ([#4777](#4777)) ([62dda2b](62dda2b))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/elasticsearchservice to v1.17.1 ([#4760](#4760)) ([02b41f6](02b41f6))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/emr to v1.20.15 ([#4761](#4761)) ([0d4e1d5](0d4e1d5))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/eventbridge to v1.16.19 ([#4762](#4762)) ([79fedc4](79fedc4))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/kinesis to v1.15.23 ([#4763](#4763)) ([ed16606](ed16606))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/kms to v1.18.17 ([#4764](#4764)) ([a43ec2a](a43ec2a))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/lambda to v1.24.11 ([#4765](#4765)) ([65fa361](65fa361))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/neptune to v1.18.2 ([#4766](#4766)) ([01d762b](01d762b))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/redshift to v1.26.15 ([#4778](#4778)) ([2c7a42e](2c7a42e))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/s3control to v1.26.0 ([#4783](#4783)) ([430164e](430164e))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/secretsmanager to v1.16.7 ([#4780](#4780)) ([15cda18](15cda18))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/servicecatalogappregistry to v1.15.0 ([#4784](#4784)) ([114ff80](114ff80))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sns to v1.18.5 ([#4781](#4781)) ([72f220d](72f220d))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/sqs to v1.19.14 ([#4786](#4786)) ([8e76293](8e76293))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/ssm to v1.33.0 ([#4785](#4785)) ([fcd03ff](fcd03ff))
* **deps:** Update module github.com/aws/aws-sdk-go-v2/service/timestreamwrite to v1.14.6 ([#4787](#4787)) ([4cc2f6b](4cc2f6b))
* Fix Name tag reference in grafana dashboard ([#4801](#4801)) ([bd38047](bd38047))
* Update endpoints ([#4732](#4732)) ([f5bb4d0](f5bb4d0))
* Update endpoints ([#4772](#4772)) ([33dc095](33dc095))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

@jsonpr jsonpr Awaiting requested review from jsonpr

@candiduslynx candiduslynx Awaiting requested review from candiduslynx

@disq disq Awaiting requested review from disq

Assignees
No one assigned
Labels
automerge Automatically merge once required checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for AWS Accounts, specifically Contact Information and Alternate Contacts
3 participants
@bbernays @hermanschaaf @cq-bot