-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DeleteStale from relational tables as well #5143
Merged
erezrokah
merged 2 commits into
cloudquery:main
from
shimonp21:fix_deletestale_relational
Nov 29, 2022
Merged
fix: DeleteStale from relational tables as well #5143
erezrokah
merged 2 commits into
cloudquery:main
from
shimonp21:fix_deletestale_relational
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimonp21
force-pushed
the
fix_deletestale_relational
branch
from
November 29, 2022 13:55
859d5d8
to
dee969c
Compare
yevgenypats
approved these changes
Nov 29, 2022
yevgenypats
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems fine but also a test will be nice (in the SDK) so our destination testing framework will catch this
This was referenced Nov 29, 2022
shimonp21
pushed a commit
that referenced
this pull request
Nov 29, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.10](plugins-destination-sqlite-v1.0.9...plugins-destination-sqlite-v1.0.10) (2022-11-29) ### Bug Fixes * DeleteStale from relational tables as well ([#5143](#5143)) ([23aa159](23aa159)) * **deps:** Update plugin-sdk for sqlite to v1.8.1 ([#5044](#5044)) ([7c085c6](7c085c6)) * **deps:** Update plugin-sdk for sqlite to v1.9.0 ([#5087](#5087)) ([9f43e46](9f43e46)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
shimonp21
added a commit
that referenced
this pull request
Nov 29, 2022
🤖 I have created a release *beep* *boop* --- ## [1.7.15](plugins-destination-postgresql-v1.7.14...plugins-destination-postgresql-v1.7.15) (2022-11-29) ### Bug Fixes * DeleteStale from relational tables as well ([#5143](#5143)) ([23aa159](23aa159)) * **deps:** Update plugin-sdk for postgresql to v1.8.1 ([#5043](#5043)) ([abd4d12](abd4d12)) * **deps:** Update plugin-sdk for postgresql to v1.9.0 ([#5085](#5085)) ([be36fb0](be36fb0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: shimonp21 <37939765+shimonp21@users.noreply.github.com>
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.3](plugins-destination-snowflake-v1.0.2...plugins-destination-snowflake-v1.0.3) (2022-11-29) ### Bug Fixes * DeleteStale from relational tables as well ([#5143](#5143)) ([23aa159](23aa159)) * **deps:** Update plugin-sdk for snowflake to v1.9.0 ([#5086](#5086)) ([0a84139](0a84139)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Won't compile until cloudquery/plugin-sdk#443 is merged.