Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fetch incidents with dateRange="all", and add query examples to docs #7184

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

shimonp21
Copy link
Contributor

@shimonp21 shimonp21 commented Jan 25, 2023

This fixes an issue where only the last month of incidents were fetched (see since parameter in https://developer.pagerduty.com/api-reference/9d0b4b12e36f9-list-incidents#Query-Parameters).

Also copied some query examples from blog to docs.

Summary

…o docs

This fixes an issue where only the last month of incidents were fetched (see `since` parameter in https://developer.pagerduty.com/api-reference/9d0b4b12e36f9-list-incidents#Query-Parameters).

Also copied some query examples from blog to docs.
@shimonp21 shimonp21 requested a review from a team as a code owner January 25, 2023 13:26
@erezrokah erezrokah changed the title fix: Fetch incidents with dateRange="all", and add query examples t… fix: Fetch incidents with dateRange="all", and add query examples to docs Jan 25, 2023
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but we should remove all // Code generated by codegen; DO NOT EDIT. from the plugin

@shimonp21 shimonp21 merged commit 0d84525 into cloudquery:main Jan 25, 2023
kodiakhq bot pushed a commit that referenced this pull request Jan 26, 2023
🤖 I have created a release *beep* *boop*
---


## [1.3.0](plugins-source-pagerduty-v1.2.2...plugins-source-pagerduty-v1.3.0) (2023-01-26)


### Features

* Pagerduty `team_ids` config ([#7206](#7206)) ([29832cf](29832cf))
* Pagerduty `team_ids` config ([#7206](#7206)) ([883f6e6](883f6e6))
* PagerDuty Rate Limiting ([#7218](#7218)) ([09fb388](09fb388))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk to v1.29.0 ([#7121](#7121)) ([b7441c9](b7441c9))
* Fetch incidents with `dateRange="all"`, and add query examples to docs ([#7184](#7184)) ([0d84525](0d84525))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants