feat: PagerDuty Rate Limiting #7218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my tests (toy account with 1000 incidents), this fixed the rate-limit errors that prevented cloudquery from getting data. Fetching '*' took 5m13s unfortunately.
shimonp21
force-pushed
the
feat_pagerduty_rate_limiting
branch
from
5ab5055
to
3b7b52c
Compare
disq
reviewed
Jan 26, 2023
erezrokah
reviewed
Jan 26, 2023
There was a problem hiding this comment.
The code looks good @shimonp21. Have you considered using a retry with a backoff when the limit is reached (similar to here)? Otherwise with the approach in this PR we can't guarantee we use the max available quota
|
@erezrokah I considered it - but because the limit is per org (https://developer.pagerduty.com/docs/ZG9jOjExMDI5NTUz-rate-limiting#what-are-our-limits), I strongly want to avoid "using all available quota" :). |
erezrokah
approved these changes
Jan 26, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
🤖 I have created a release *beep* *boop* --- ## [1.3.0](plugins-source-pagerduty-v1.2.2...plugins-source-pagerduty-v1.3.0) (2023-01-26) ### Features * Pagerduty `team_ids` config ([#7206](#7206)) ([29832cf](29832cf)) * Pagerduty `team_ids` config ([#7206](#7206)) ([883f6e6](883f6e6)) * PagerDuty Rate Limiting ([#7218](#7218)) ([09fb388](09fb388)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.29.0 ([#7121](#7121)) ([b7441c9](b7441c9)) * Fetch incidents with `dateRange="all"`, and add query examples to docs ([#7184](#7184)) ([0d84525](0d84525)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
amanenk
pushed a commit
to amanenk/cloudquery
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my tests (toy account with 1000 incidents), this fixed the rate-limit errors that prevented cloudquery from getting data. Fetching '*' took 5m13s unfortunately.
I used the
RateLimitHttpClientinstead of just callinglimiter.Waitbefore every call, since some calls are paginated by the SDK (i.e. theforloop is in thepagerduty-gosdk).mention: #6981