Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws)!: Step Function Executions And MapRuns #8130

Merged
merged 6 commits into from
Feb 15, 2023
Merged

fix(aws)!: Step Function Executions And MapRuns #8130

merged 6 commits into from
Feb 15, 2023

Conversation

bbernays
Copy link
Collaborator

@bbernays bbernays commented Feb 15, 2023 •
edited

Summary

I have validated that data is able to be populated in all tables:
Screenshot 2023-02-15 at 9 18 19 AM

With no errors or panics
Screenshot 2023-02-15 at 9 18 53 AM

@github-actions
Copy link

github-actions bot commented Feb 15, 2023 •
edited

This PR has the following changes to source plugin(s) tables:

  • Table aws_stepfunctions_executions: column order changed for state_machine_arn
  • Table aws_stepfunctions_map_run_executions was added
  • ⚠️ BREAKING CHANGE: Table aws_stepfunctions_executions_map_runs was renamed to aws_stepfunctions_map_runs
  • Table aws_stepfunctions_map_runs: column added with name state_machine_arn and type String

disq
disq approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR prefix needs to be fix(aws)! because of the breaking (breaking what's already broken I know) change

@bbernays bbernays changed the title fix(aws): Step Function Executions And MapRuns fix(aws)!: Step Function Executions And MapRuns Feb 15, 2023
@bbernays bbernays added the automerge Automatically merge once required checks pass label Feb 15, 2023
@kodiakhq kodiakhq bot merged commit 21e4ea1 into cloudquery:main Feb 15, 2023
@cq-bot cq-bot mentioned this pull request Feb 15, 2023
Merged
@bbernays bbernays deleted the fix-sfn branch February 15, 2023 17:46
kodiakhq bot pushed a commit that referenced this pull request Feb 15, 2023
@cq-bot
chore(main): Release plugins-source-aws v15.0.0 (#8120)
8d629ff 
🤖 I have created a release *beep* *boop*
---


## [15.0.0](plugins-source-aws-v14.0.0...plugins-source-aws-v15.0.0) (2023-02-15)


### ⚠ BREAKING CHANGES

* **aws:** Step Function Executions And MapRuns ([#8130](#8130))
* **aws:** Add `arn` to `aws_ec2_managed_prefix_lists` PK ([#8119](#8119))

### Bug Fixes

* **aws:** Add `arn` to `aws_ec2_managed_prefix_lists` PK ([#8119](#8119)) ([148b06c](148b06c))
* **aws:** Step Function Executions And MapRuns ([#8130](#8130)) ([21e4ea1](21e4ea1))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disq disq disq approved these changes

@yevgenypats yevgenypats yevgenypats approved these changes

@hermanschaaf hermanschaaf Awaiting requested review from hermanschaaf

Assignees
No one assigned
Labels
automerge Automatically merge once required checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbernays @disq @yevgenypats @cq-bot