Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed level of bad config diagnostics #822

Merged
merged 4 commits into from
Jun 1, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Jun 1, 2022

πŸŽ‰ Thank you for making CloudQuery awesome by submitting a PR πŸŽ‰

Summary

  • changed level of bad config to USER
  • added printing of diags

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests πŸ§ͺ
  • Ensure the status checks below are successful βœ…

pkg/ui/console/client.go Outdated Show resolved Hide resolved
@amanenk amanenk requested a review from roneli June 1, 2022 10:49
@amanenk amanenk marked this pull request as ready for review June 1, 2022 10:49
@amanenk amanenk requested a review from a team as a code owner June 1, 2022 10:49
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli added the bug label Jun 1, 2022
@roneli roneli merged commit 67b0bd3 into cloudquery:main Jun 1, 2022
kodiakhq bot pushed a commit that referenced this pull request Jun 2, 2022
πŸ€– I have created a release *beep* *boop*
---


### [0.24.6](v0.24.5...v0.24.6) (2022-06-01)


### Features

* Add goroutine count to sentry ([#825](#825)) ([d4d56c2](d4d56c2))


### Bug Fixes

* Bad condition db version analytics ([#829](#829)) ([6cd8d6d](6cd8d6d))
* Changed level of bad config diagnostics ([#822](#822)) ([67b0bd3](67b0bd3))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.7 ([#826](#826)) ([f075726](f075726))
* Don't fail on PG_TRGM missing ([#821](#821)) ([a0672b5](a0672b5)), closes [#816](#816)
* Incorrect diagnostics summary count ([#823](#823)) ([58760b4](58760b4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Jun 6, 2022
* upstream/main: (36 commits)
  chore(main): Release v0.24.9 (cloudquery#847)
  fix: Improve missing git binary message (cloudquery#846)
  chore: Synced file(s) with cloudquery/.github (cloudquery#845)
  chore: Synced file(s) with cloudquery/.github (cloudquery#844)
  chore(main): Release v0.24.8 (cloudquery#839)
  feat: Change minimum postgres version to 10 (cloudquery#838)
  chore: Synced file(s) with cloudquery/.github (cloudquery#837)
  chore: Synced file(s) with cloudquery/.github (cloudquery#835)
  fix: Disable Telemetry with special CQ team cookie (cloudquery#832)
  chore(main): Release v0.24.7 (cloudquery#831)
  fix: Policy Output Table (cloudquery#830)
  chore(main): Release v0.24.6 (cloudquery#824)
  fix: Bad condition db version analytics (cloudquery#829)
  chore: Synced file(s) with cloudquery/.github (cloudquery#827)
  fix(deps): Update module github.com/cloudquery/cq-provider-sdk to v0.10.7 (cloudquery#826)
  feat: Add goroutine count to sentry (cloudquery#825)
  fix: Incorrect diagnostics summary count (cloudquery#823)
  fix: Changed level of bad config diagnostics (cloudquery#822)
  fix: Don't fail on PG_TRGM missing (cloudquery#821)
  chore(main): Release v0.24.5 (cloudquery#820)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants