Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default alias to name #966

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Jun 21, 2022

πŸŽ‰ Thank you for making CloudQuery awesome by submitting a PR πŸŽ‰

Summary

Fixes YAML parsing as we expect provider alias to default to name


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests πŸ§ͺ
  • Ensure the status checks below are successful βœ…

@erezrokah erezrokah requested a review from a team as a code owner June 21, 2022 11:46
@erezrokah erezrokah requested review from bbernays and removed request for a team June 21, 2022 11:46
@shimonp21 shimonp21 requested a review from disq June 21, 2022 12:02
@disq disq merged commit 706447c into cloudquery:main Jun 21, 2022
kodiakhq bot pushed a commit that referenced this pull request Jun 21, 2022
πŸ€– I have created a release *beep* *boop*
---


## [0.27.0-rc2](v0.27.0-rc1...v0.27.0-rc2) (2022-06-21)


### Bug Fixes

* Default alias to name ([#966](#966)) ([706447c](706447c))
* Support modules tag in config ([#965](#965)) ([379344f](379344f))


### Miscellaneous Chores

* Release 0.27.0-rc2 ([#967](#967)) ([cd37a11](cd37a11))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit that referenced this pull request Jun 22, 2022
πŸ€– I have created a release *beep* *boop*
---


## [0.27.0](v0.26.4...v0.27.0) (2022-06-22)


### ⚠ BREAKING CHANGES

* Remove drift (#887)

### Features

* Remove drift ([#887](#887)) ([3d387bd](3d387bd))
* Add YAML configuration support ([#887](#887)) ([3d387bd](3d387bd))

### Bug Fixes

* Default alias to name ([#966](#966)) ([706447c](706447c))
* Support modules tag in config ([#965](#965)) ([379344f](379344f))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.12.1 ([#972](#972)) ([1f871e9](1f871e9))
* Request correct config format (YAML) from provider ([#968](#968)) ([999b68d](999b68d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@erezrokah erezrokah deleted the fix/default_alias_to_name branch August 9, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants