Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Choose correct region for S3 #1216

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

bbernays
Copy link
Contributor

Summary


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here πŸ§ͺ
  • Update the docs by running go run ./docs/docs.go and committing the changes πŸ“ƒ
  • If adding a new resource, add relevant Terraform files in a separate PR πŸ“‚
  • Ensure the status checks below are successful βœ…

@bbernays bbernays requested a review from a team as a code owner July 12, 2022 19:46
@bbernays bbernays requested review from hermanschaaf and removed request for a team July 12, 2022 19:46
@bbernays bbernays linked an issue Jul 12, 2022 that may be closed by this pull request
@bbernays bbernays merged commit e75f91b into cloudquery:main Jul 13, 2022
@bbernays bbernays deleted the fix-s3-for-partitions branch July 13, 2022 11:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListBucket report 400
2 participants