Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Policies #1220

Merged
merged 11 commits into from
Jul 18, 2022
Merged

feat: Policies #1220

merged 11 commits into from
Jul 18, 2022

Conversation

disq
Copy link
Member

@disq disq commented Jul 14, 2022

Adds SQL policies to the provider. We will follow up with more details soon.

@disq disq requested a review from yevgenypats July 14, 2022 17:10
@disq disq marked this pull request as ready for review July 14, 2022 19:57
@disq disq requested a review from a team as a code owner July 14, 2022 19:57
Copy link
Member

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just small comment on the test policy. Also once that working remember to move it to .github

.github/workflows/test_policy_sql.yml Outdated Show resolved Hide resolved
@disq disq requested a review from yevgenypats July 15, 2022 09:11
Copy link
Member

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just had one nit. Let's remove the sql folder (put everything directly under policies)?

.github/workflows/test_policy_sql.yml Outdated Show resolved Hide resolved
@yevgenypats yevgenypats merged commit 8a2cb92 into main Jul 18, 2022
@yevgenypats yevgenypats deleted the feat/policies branch July 18, 2022 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants