Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Ignore CF distributions NoSuchResource on ListTags #1238

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix: Ignore CF distributions NoSuchResource on ListTags #1238

merged 1 commit into from
Jul 22, 2022

Conversation

zagronitay
Copy link
Contributor

@zagronitay zagronitay commented Jul 19, 2022 •
edited
Loading

Summary

closes cloudquery/cloudquery-issues#432

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@zagronitay zagronitay requested a review from a team as a code owner July 19, 2022 10:14
@zagronitay zagronitay requested review from irmatov and removed request for a team July 19, 2022 10:14
amanenk
amanenk approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@amanenk amanenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbernays bbernays merged commit 01efd1a into cloudquery:main Jul 22, 2022
@cq-bot cq-bot mentioned this pull request Jul 22, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amanenk amanenk amanenk approved these changes

@irmatov irmatov Awaiting requested review from irmatov irmatov is a code owner automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zagronitay @amanenk @bbernays