Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Added lightsail disks #1240

Merged
merged 8 commits into from
Jul 21, 2022
Merged

feat: Added lightsail disks #1240

merged 8 commits into from
Jul 21, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Jul 19, 2022 •
edited
Loading

Summary

closes #774

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@amanenk amanenk marked this pull request as ready for review July 19, 2022 13:18
@amanenk amanenk requested a review from a team as a code owner July 19, 2022 13:18
@amanenk amanenk requested review from zagronitay and removed request for a team July 19, 2022 13:18
@amanenk
fix
5c4a472
@amanenk
Merge branch 'main' into lightsail_disks
be6b7d3 
# Conflicts:
#	client/services.go
#	resources/services/lightsail/gen.hcl
@amanenk
fix docs
07cb09b
@amanenk
fix
d1995c3
@amanenk amanenk requested a review from bbernays July 21, 2022 15:59
@amanenk amanenk merged commit fab23e0 into cloudquery:main Jul 21, 2022
@cq-bot cq-bot mentioned this pull request Jul 21, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@zagronitay zagronitay Awaiting requested review from zagronitay zagronitay is a code owner automatically assigned from cloudquery/cloudquery-opensource

@shimonp21 shimonp21 Awaiting requested review from shimonp21

@bbernays bbernays Awaiting requested review from bbernays

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS::Lightsail::Disk
3 participants
@amanenk @hermanschaaf @bbernays