Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Added lightsail alarms #1242

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Jul 19, 2022

Summary

closes #769


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here πŸ§ͺ
  • Update the docs by running go run ./docs/docs.go and committing the changes πŸ“ƒ
  • If adding a new resource, add relevant Terraform files in a separate PR πŸ“‚
  • Ensure the status checks below are successful βœ…

@amanenk amanenk marked this pull request as ready for review July 19, 2022 14:38
@amanenk amanenk requested a review from a team as a code owner July 19, 2022 14:38
@amanenk amanenk requested review from shimonp21, hermanschaaf and bbernays and removed request for a team July 19, 2022 14:38
@hermanschaaf
Copy link
Member

Not sure why the integration tests are failing πŸ€”

@amanenk amanenk requested a review from shimonp21 July 20, 2022 10:58
@amanenk amanenk merged commit 19e3476 into cloudquery:main Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::Lightsail::Alarm
4 participants