Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Added lightsail database snapshots #1263

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Jul 22, 2022

Summary

closes #1250


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here πŸ§ͺ
  • Update the docs by running go run ./docs/docs.go and committing the changes πŸ“ƒ
  • If adding a new resource, add relevant Terraform files in a separate PR πŸ“‚
  • Ensure the status checks below are successful βœ…

Copy link
Contributor

@irmatov irmatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amanenk amanenk marked this pull request as ready for review July 22, 2022 10:01
@amanenk amanenk requested a review from a team as a code owner July 22, 2022 10:01
@amanenk amanenk requested review from disq and removed request for a team July 22, 2022 10:01
# Conflicts:
#	client/mocks/mock_lightsail.go
#	client/services.go
#	resources/provider/provider.go
#	resources/services/lightsail/gen.hcl
@amanenk amanenk merged commit 6749225 into cloudquery:main Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::Lightsail::RelationalDatabaseSnapshot
2 participants