Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Remove regional override #1276

Merged
merged 8 commits into from
Aug 8, 2022
Merged

feat: Remove regional override #1276

merged 8 commits into from
Aug 8, 2022

Conversation

bbernays
Copy link
Contributor

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays requested a review from a team as a code owner July 22, 2022 22:18
@bbernays bbernays requested review from disq and removed request for a team July 22, 2022 22:18
disq
disq approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bbernays bbernays merged commit 7f8025a into cloudquery:main Aug 8, 2022
@bbernays bbernays deleted the remove-regional-override branch August 8, 2022 13:41
@cq-bot cq-bot mentioned this pull request Aug 8, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@disq disq disq approved these changes

@yevgenypats yevgenypats yevgenypats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbernays @disq @yevgenypats