This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
feat: Implement Glue registries resource #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irmatov
requested review from
shimonp21 and
amanenk
and removed request for
a team
amanenk
approved these changes
Aug 1, 2022
|
@irmatov If you bring this branch up to date with the main branch, the integration tests should no longer be a requirement and I'd expect the build to pass. |
# Conflicts: # client/mocks/glue.go # resources/provider/provider.go
added version metadata
# Conflicts: # client/mocks/glue.go # client/services.go # resources/provider/provider.go
hermanschaaf
reviewed
Aug 4, 2022
hermanschaaf
approved these changes
Aug 4, 2022
# Conflicts: # client/mocks/glue.go
candiduslynx
suggested changes
Aug 4, 2022
bbernays
approved these changes
Aug 5, 2022
candiduslynx
approved these changes
Aug 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1324