Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Add tags for Cloudwatch alarms #1374

Merged
merged 2 commits into from
Aug 2, 2022
Merged

feat: Add tags for Cloudwatch alarms #1374

merged 2 commits into from
Aug 2, 2022

Conversation

Barneyjm
Copy link
Contributor

@Barneyjm Barneyjm commented Aug 2, 2022 •
edited
Loading

Summary

resolves #1371

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • [🚨] Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@Barneyjm Barneyjm requested a review from a team as a code owner August 2, 2022 17:36
@Barneyjm Barneyjm requested review from yevgenypats and removed request for a team August 2, 2022 17:36
@Barneyjm Barneyjm changed the title Cw alarm tags feat: Add tags for Cloudwatch alarms Aug 2, 2022
@bbernays bbernays merged commit 07bd11b into cloudquery:main Aug 2, 2022
@cq-bot cq-bot mentioned this pull request Aug 2, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbernays bbernays bbernays approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats yevgenypats is a code owner automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_cloudwatch_alarms support tags but CQ doesn't pull them
2 participants
@Barneyjm @bbernays