feat: Simplify Resources

[bbernays]

Summary

More simplification of resource resolvers

---

Use the following steps to ensure your PR is ready to be reviewed

• Read the contribution guidelines 🧑‍🎓
• Run go fmt to format your code 🖊
• Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
• Update or add tests. Learn more about testing here 🧪
• Update the docs by running go run ./docs/docs.go and committing the changes 📃
• If adding a new resource, add relevant Terraform files in a separate PR 📂
• Ensure the status checks below are successful ✅

[hermanschaaf]

@bbernays it looks like the PR contains a couple of commits from another branch and will need to be rebased

[hermanschaaf]

Maybe I'm missing something, but I think this is already possible. When using cq-gen, you can set the column type to be JSON. AFAICT It then uses PathResolver and does the JSON conversion for you.

Here is a test case for this in cq-gen:

• input: https://github.com/cloudquery/cq-gen/blob/main/codegen/tests/columns.hcl#L64-L72
• and the expectation: https://github.com/cloudquery/cq-gen/blob/main/codegen/tests/expected/columns/change_type_default_resolver.go#L22-L26

So I'm not sure where PathJSONResolver would be needed?

[bbernays]

I fully agree that if PathResolver can do the marshaling then this resolver is 100% not necessary.
@roneli, @amanenk and @irmatov Can speak to why we have so many resolvers like this that as @hermanschaaf points out could possibly be handled by the PathResolver

cq-provider-aws/resources/services/waf/web_acls.go

Lines 254 to 263 in 01b56da

	func resolveWafWebACLLoggingConfigurationRedactedFields(ctx context.Context, meta schema.ClientMeta, resource *schema.Resource, c schema.Column) error {
	if conf := resource.Item.(*types.LoggingConfiguration); conf != nil {
	out, err := json.Marshal(conf.RedactedFields)
	if err != nil {
	return diag.WrapError(err)
	}
	return diag.WrapError(resource.Set(c.Name, out))
	}
	return nil
	}

[bbernays]

As @hermanschaaf has pointed out, this resolver is not necessary as our internal implementation for json columns already calls json.marshal
https://github.com/cloudquery/cq-provider-sdk/blob/76ac8db01622b520bbacfe0272ab38233eb1abdf/provider/schema/dialect.go#L242-L251

[amanenk]

It is totally fine to regenerate all the resources and use PathResolver. Before some sdk implementations not all the structures had automatically marshaled to json.

[erezrokah]

🧹