Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: More Resource Simplification #1399

Merged
merged 11 commits into from
Aug 8, 2022
Merged

feat: More Resource Simplification #1399

merged 11 commits into from
Aug 8, 2022

Conversation

bbernays
Copy link
Contributor

@bbernays bbernays commented Aug 8, 2022

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • Ensure the status checks below are successful ✅

@bbernays bbernays requested a review from a team as a code owner August 8, 2022 14:42
@bbernays bbernays requested review from amanenk and removed request for a team August 8, 2022 14:42
amanenk
amanenk approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@amanenk amanenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbernays bbernays merged commit 902c8e0 into cloudquery:main Aug 8, 2022
@bbernays bbernays deleted the simplify branch August 8, 2022 14:54
@cq-bot cq-bot mentioned this pull request Aug 8, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amanenk amanenk amanenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbernays @amanenk