This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
fix(build): Don't filter paths and enforce //check-for-changes on new cq-gen config files #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
requested review from
spangenberg and
erezrokah
and removed request for
a team and
spangenberg
|
Once approved, I will port this to the (open PRs for) other provider repos as well (GCP, Azure, etc) |
erezrokah
approved these changes
Aug 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the workflow that checks for generated code drift in two ways:
paths-filterplugin ensures we stop early if no relevant files changed.//check-for-changesis used in all new cq-gen config files