feat: Fix for UUID #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
approved these changes
Oct 23, 2023
2 tasks
2 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
🤖 I have created a release *beep* *boop* --- ## [0.1.7](v0.1.6...v0.1.7) (2023-10-23) ### Bug Fixes * **deps:** Update dependency pyarrow to v13 ([#53](#53)) ([55bed05](55bed05)) * Properly handle `uuid.UUID` values in scalars ([#70](#70)), closes (cloudquery/cloudquery#14825) ([1fc0cf7](1fc0cf7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the Marshalling for the UUID Scalar.
Referenced in: cloudquery/cloudquery#14825
It assumes Network-Order Bytes as per https://www.rfc-editor.org/rfc/rfc4122.html#section-4.1.1
This should work as it does pass the tests, but our testing framework is a little incomplete.
I'm not going to alter the test framework in this commit - But we should have a Marshalling test that confirms the expected bytes are created for each custom object type.
Fixes cloudquery/cloudquery#14825
BEGIN_COMMIT_OVERRIDE
fix: Properly handle
uuid.UUIDvalues in scalars (#70), closes (cloudquery/cloudquery#14825)END_COMMIT_OVERRIDE