-
Notifications
You must be signed in to change notification settings - Fork 22
/
batchwriter.go
338 lines (309 loc) · 8.8 KB
/
batchwriter.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
package batchwriter
import (
"context"
"fmt"
"sync"
"time"
"github.com/apache/arrow/go/v15/arrow/util"
"github.com/cloudquery/plugin-sdk/v4/message"
"github.com/cloudquery/plugin-sdk/v4/schema"
"github.com/cloudquery/plugin-sdk/v4/writers"
"github.com/rs/zerolog"
)
type Client interface {
MigrateTables(context.Context, message.WriteMigrateTables) error
WriteTableBatch(ctx context.Context, name string, messages message.WriteInserts) error
DeleteStale(context.Context, message.WriteDeleteStales) error
DeleteRecord(context.Context, message.WriteDeleteRecords) error
}
type BatchWriter struct {
client Client
workers map[string]*worker
workersLock sync.RWMutex
workersWaitGroup sync.WaitGroup
migrateTableLock sync.Mutex
migrateTableMessages message.WriteMigrateTables
deleteStaleLock sync.Mutex
deleteStaleMessages message.WriteDeleteStales
deleteRecordLock sync.Mutex
deleteRecordMessages message.WriteDeleteRecords
logger zerolog.Logger
batchTimeout time.Duration
batchSize int
batchSizeBytes int
}
// Assert at compile-time that BatchWriter implements the Writer interface
var _ writers.Writer = (*BatchWriter)(nil)
type Option func(*BatchWriter)
func WithLogger(logger zerolog.Logger) Option {
return func(p *BatchWriter) {
p.logger = logger
}
}
func WithBatchTimeout(timeout time.Duration) Option {
return func(p *BatchWriter) {
p.batchTimeout = timeout
}
}
func WithBatchSize(size int) Option {
return func(p *BatchWriter) {
p.batchSize = size
}
}
func WithBatchSizeBytes(size int) Option {
return func(p *BatchWriter) {
p.batchSizeBytes = size
}
}
type worker struct {
ch chan *message.WriteInsert
flush chan chan bool
}
const (
defaultBatchTimeoutSeconds = 20
defaultBatchSize = 10000
defaultBatchSizeBytes = 5 * 1024 * 1024 // 5 MiB
)
func New(client Client, opts ...Option) (*BatchWriter, error) {
c := &BatchWriter{
client: client,
workers: make(map[string]*worker),
logger: zerolog.Nop(),
batchTimeout: defaultBatchTimeoutSeconds * time.Second,
batchSize: defaultBatchSize,
batchSizeBytes: defaultBatchSizeBytes,
}
for _, opt := range opts {
opt(c)
}
c.migrateTableMessages = make([]*message.WriteMigrateTable, 0, c.batchSize)
c.deleteStaleMessages = make([]*message.WriteDeleteStale, 0, c.batchSize)
return c, nil
}
func (w *BatchWriter) Flush(ctx context.Context) error {
w.workersLock.RLock()
for _, worker := range w.workers {
done := make(chan bool)
worker.flush <- done
<-done
}
w.workersLock.RUnlock()
if err := w.flushMigrateTables(ctx); err != nil {
return err
}
return w.flushDeleteStaleTables(ctx)
}
func (w *BatchWriter) Close(context.Context) error {
w.workersLock.Lock()
defer w.workersLock.Unlock()
for _, w := range w.workers {
close(w.ch)
}
w.workersWaitGroup.Wait()
return nil
}
func (w *BatchWriter) worker(ctx context.Context, tableName string, ch <-chan *message.WriteInsert, flush <-chan chan bool) {
sizeBytes := int64(0)
resources := make([]*message.WriteInsert, 0, w.batchSize)
ticker := writers.NewTicker(w.batchTimeout)
defer ticker.Stop()
for {
select {
case r, ok := <-ch:
if !ok {
if len(resources) > 0 {
w.flushTable(ctx, tableName, resources)
}
return
}
if (w.batchSize > 0 && len(resources) >= w.batchSize) || (w.batchSizeBytes > 0 && sizeBytes+util.TotalRecordSize(r.Record) >= int64(w.batchSizeBytes)) {
w.flushTable(ctx, tableName, resources)
ticker.Reset(w.batchTimeout)
resources, sizeBytes = resources[:0], 0
}
resources = append(resources, r)
sizeBytes += util.TotalRecordSize(r.Record)
case <-ticker.Chan():
if len(resources) > 0 {
w.flushTable(ctx, tableName, resources)
ticker.Reset(w.batchTimeout)
resources, sizeBytes = resources[:0], 0
}
case done := <-flush:
if len(resources) > 0 {
w.flushTable(ctx, tableName, resources)
ticker.Reset(w.batchTimeout)
resources, sizeBytes = resources[:0], 0
}
done <- true
case <-ctx.Done():
// this means the request was cancelled
return // after this NO other call will succeed
}
}
}
func (w *BatchWriter) flushTable(ctx context.Context, tableName string, resources []*message.WriteInsert) {
// resources = w.removeDuplicatesByPK(table, resources)
start := time.Now()
batchSize := len(resources)
if err := w.client.WriteTableBatch(ctx, tableName, resources); err != nil {
w.logger.Err(err).Str("table", tableName).Int("len", batchSize).Dur("duration", time.Since(start)).Msg("failed to write batch")
} else {
w.logger.Info().Str("table", tableName).Int("len", batchSize).Dur("duration", time.Since(start)).Msg("batch written successfully")
}
}
func (w *BatchWriter) flushMigrateTables(ctx context.Context) error {
w.migrateTableLock.Lock()
defer w.migrateTableLock.Unlock()
if len(w.migrateTableMessages) == 0 {
return nil
}
if err := w.client.MigrateTables(ctx, w.migrateTableMessages); err != nil {
return err
}
w.migrateTableMessages = w.migrateTableMessages[:0]
return nil
}
func (w *BatchWriter) flushDeleteStaleTables(ctx context.Context) error {
w.deleteStaleLock.Lock()
defer w.deleteStaleLock.Unlock()
if len(w.deleteStaleMessages) == 0 {
return nil
}
if err := w.client.DeleteStale(ctx, w.deleteStaleMessages); err != nil {
return err
}
w.deleteStaleMessages = w.deleteStaleMessages[:0]
return nil
}
func (w *BatchWriter) flushDeleteRecordTables(ctx context.Context) error {
w.deleteRecordLock.Lock()
defer w.deleteRecordLock.Unlock()
if len(w.deleteRecordMessages) == 0 {
return nil
}
if err := w.client.DeleteRecord(ctx, w.deleteRecordMessages); err != nil {
return err
}
w.deleteRecordMessages = w.deleteRecordMessages[:0]
return nil
}
func (w *BatchWriter) flushInsert(tableName string) {
w.workersLock.RLock()
worker, ok := w.workers[tableName]
if !ok {
w.workersLock.RUnlock()
// no tables to flush
return
}
w.workersLock.RUnlock()
ch := make(chan bool)
worker.flush <- ch
<-ch
}
func (w *BatchWriter) writeAll(ctx context.Context, msgs []message.WriteMessage) error {
ch := make(chan message.WriteMessage, len(msgs))
for _, msg := range msgs {
ch <- msg
}
close(ch)
return w.Write(ctx, ch)
}
func (w *BatchWriter) Write(ctx context.Context, msgs <-chan message.WriteMessage) error {
for msg := range msgs {
switch m := msg.(type) {
case *message.WriteDeleteStale:
if err := w.flushMigrateTables(ctx); err != nil {
return err
}
w.flushInsert(m.TableName)
w.deleteStaleLock.Lock()
w.deleteStaleMessages = append(w.deleteStaleMessages, m)
l := len(w.deleteStaleMessages)
w.deleteStaleLock.Unlock()
if w.batchSize > 0 && l > w.batchSize {
if err := w.flushDeleteStaleTables(ctx); err != nil {
return err
}
}
case *message.WriteDeleteRecord:
if err := w.flushMigrateTables(ctx); err != nil {
return err
}
if err := w.flushDeleteStaleTables(ctx); err != nil {
return err
}
// Ensure all related workers are flushed
for _, rel := range m.TableRelations {
w.flushInsert(rel.TableName)
}
w.deleteRecordLock.Lock()
w.deleteRecordMessages = append(w.deleteRecordMessages, m)
l := len(w.deleteRecordMessages)
w.deleteRecordLock.Unlock()
if w.batchSize > 0 && l > w.batchSize {
if err := w.flushDeleteRecordTables(ctx); err != nil {
return err
}
}
case *message.WriteInsert:
if err := w.flushMigrateTables(ctx); err != nil {
return err
}
if err := w.flushDeleteStaleTables(ctx); err != nil {
return err
}
if err := w.startWorker(ctx, m); err != nil {
return err
}
case *message.WriteMigrateTable:
w.flushInsert(m.Table.Name)
if err := w.flushDeleteStaleTables(ctx); err != nil {
return err
}
w.migrateTableLock.Lock()
w.migrateTableMessages = append(w.migrateTableMessages, m)
l := len(w.migrateTableMessages)
w.migrateTableLock.Unlock()
if w.batchSize > 0 && l > w.batchSize {
if err := w.flushMigrateTables(ctx); err != nil {
return err
}
}
}
}
return nil
}
func (w *BatchWriter) startWorker(_ context.Context, msg *message.WriteInsert) error {
w.workersLock.RLock()
md := msg.Record.Schema().Metadata()
tableName, ok := md.GetValue(schema.MetadataTableName)
if !ok {
w.workersLock.RUnlock()
return fmt.Errorf("table name not found in metadata")
}
wr, ok := w.workers[tableName]
w.workersLock.RUnlock()
if ok {
wr.ch <- msg
return nil
}
w.workersLock.Lock()
ch := make(chan *message.WriteInsert)
flush := make(chan chan bool)
wr = &worker{
ch: ch,
flush: flush,
}
w.workers[tableName] = wr
w.workersLock.Unlock()
w.workersWaitGroup.Add(1)
go func() {
defer w.workersWaitGroup.Done()
// TODO: we need to create a cancellable context that then can be cancelled via
// w.cancelWorkers()
w.worker(context.Background(), tableName, ch, flush)
}()
ch <- msg
return nil
}