Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Warning validation in form field and input components #1982

Merged
merged 30 commits into from
May 2, 2024

Conversation

cansuaa
Copy link
Contributor

@cansuaa cansuaa commented Feb 19, 2024

Description

Added warningText API to form field, attribute-editor and file-upload, added warning API to input components.

Visual regression tests are failing due to the new changes done in pages

How has this been tested?

Locally

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.37%. Comparing base (23c9b8e) to head (eddb136).
Report is 1 commits behind head on main.

Files Patch % Lines
src/test-utils/dom/file-upload/index.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1982      +/-   ##
==========================================
- Coverage   95.37%   95.37%   -0.01%     
==========================================
  Files         696      696              
  Lines       18584    18624      +40     
  Branches     6200     5908     -292     
==========================================
+ Hits        17725    17763      +38     
- Misses        805      854      +49     
+ Partials       54        7      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cansuaa cansuaa changed the title WIP: warning validation in form field feat: WIP warning validation in form field Feb 23, 2024
@cansuaa cansuaa changed the title feat: WIP warning validation in form field feat: Warning validation in form field and input components Feb 28, 2024
Al-Dani
Al-Dani previously approved these changes Apr 19, 2024
Al-Dani
Al-Dani previously approved these changes Apr 29, 2024
@cansuaa cansuaa merged commit 4bb4d54 into main May 2, 2024
43 of 44 checks passed
@cansuaa cansuaa deleted the feat/warning-validation-form-field branch May 2, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants