-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Warning validation in form field and input components #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1982 +/- ##
==========================================
- Coverage 95.37% 95.37% -0.01%
==========================================
Files 696 696
Lines 18584 18624 +40
Branches 6200 5908 -292
==========================================
+ Hits 17725 17763 +38
- Misses 805 854 +49
+ Partials 54 7 -47 ☔ View full report in Codecov by Sentry. |
rubencarvalho
changed the title
WIP warning validation in form field
WIP: warning validation in form field
Feb 19, 2024
cansuaa
changed the title
WIP: warning validation in form field
feat: WIP warning validation in form field
Feb 23, 2024
cansuaa
changed the title
feat: WIP warning validation in form field
feat: Warning validation in form field and input components
Feb 28, 2024
cansuaa
had a problem deploying
to
visual-regression-report
April 9, 2024 08:08
— with
GitHub Actions
Failure
cansuaa
had a problem deploying
to
visual-regression-report
April 16, 2024 10:20
— with
GitHub Actions
Failure
Al-Dani
previously approved these changes
Apr 19, 2024
cansuaa
had a problem deploying
to
visual-regression-report
April 19, 2024 12:31
— with
GitHub Actions
Failure
cansuaa
had a problem deploying
to
visual-regression-report
April 29, 2024 12:05
— with
GitHub Actions
Failure
cansuaa
had a problem deploying
to
visual-regression-report
April 29, 2024 12:12
— with
GitHub Actions
Failure
Al-Dani
previously approved these changes
Apr 29, 2024
cansuaa
had a problem deploying
to
visual-regression-report
April 30, 2024 14:30
— with
GitHub Actions
Failure
cansuaa
had a problem deploying
to
visual-regression-report
April 30, 2024 14:38
— with
GitHub Actions
Failure
cansuaa
had a problem deploying
to
visual-regression-report
April 30, 2024 15:04
— with
GitHub Actions
Failure
Al-Dani
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added warningText API to form field, attribute-editor and file-upload, added warning API to input components.
Visual regression tests are failing due to the new changes done in pages
How has this been tested?
Locally
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.