Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: update css class naming prefix #228

Closed
2 tasks done
square-li opened this issue Aug 31, 2022 · 2 comments
Closed
2 tasks done

[Feature Request]: update css class naming prefix #228

square-li opened this issue Aug 31, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@square-li
Copy link

Description

Current classnames are prefixed with awsui_. For example,

import * as React from "react";
import Box from "@cloudscape-design/components/box";

export default () => {
  return <Box variant="p">text</Box>;
}

will be rendered as

<p class="awsui_root_18wu0_1xtkt_93 awsui_box_18wu0_1xtkt_205 awsui_p-variant_18wu0_1xtkt_205 awsui_color-default_18wu0_1xtkt_205 awsui_font-size-default_18wu0_1xtkt_221 awsui_font-weight-default_18wu0_1xtkt_261">text</p>

As the lib is not called awsui, maybe changing the prefix to something likecloudscape_design or cs_?

Code of Conduct

@square-li square-li added the enhancement New feature or request label Aug 31, 2022
@abdhalees
Copy link
Member

Hello Bill,

This change would be backward incompatible with earlier versions as these classes are used by consumers for integration testing.
also we don't consider this information "awsui" as private so we're okay with exposing it in the library's internal implementation

@square-li
Copy link
Author

Right that makes sense. Thanks for the explanation.

@just-boris just-boris closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants