Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object mapper in worker mbean #22

Closed
orius123 opened this issue Feb 20, 2015 · 3 comments
Closed

object mapper in worker mbean #22

orius123 opened this issue Feb 20, 2015 · 3 comments
Assignees
Milestone

Comments

@orius123
Copy link
Contributor

@meirwah why do we need objectmapper in workermbean? And why do we initialize it in post construct. It has impact on score load time.

@meirwah
Copy link

meirwah commented Feb 20, 2015

it seems to be used only in the method "showWorkers" (Returns a list of all registered workers), i do not think this feature/method is really used in OO, so i think we can removed it...
We need to validate this of course...

how big in the impact on score load time?

@orius123
Copy link
Contributor Author

Depends.. but it can take up to a whole second because it scans the classpath for some annotations. We can work around it but if it is not required, I say we remove it / replace with gson / move init into the show workers method.

@meirwah
Copy link

meirwah commented Feb 20, 2015

👍

@oritstone oritstone added this to the 0.7 milestone Mar 2, 2015
@oritstone oritstone assigned oritstone and unassigned orius123 Mar 2, 2015
levice14 pushed a commit that referenced this issue Jul 18, 2016
Merge pull request #112 from genadi-hp/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants