Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more robust handling for Date and Timestamp types #219

Closed
agasheesh opened this issue Nov 9, 2021 · 1 comment
Closed

Add more robust handling for Date and Timestamp types #219

agasheesh opened this issue Nov 9, 2021 · 1 comment
Assignees

Comments

@agasheesh
Copy link
Collaborator

Currently HarbourBridge assumes Date and Timestamp to follow ISO 8601 format and the data migration would fail if that is not the case. We should improve our handling of these types such that either customers can provide --dateFormat and --timestampFormat as flags or HarbourBridge could add support for detecting and using a few common formats.

A side note for PostgreSQL dialect Spanner databases as target: PG Spanner doesn't support Date as of this writing and we simply treat any input date as a string and store it as a string in Spanner. This can lead to dates such as "2021-42-1009" being written verbatim. One potential improvement would be to try and parse dates using the expanded list of valid formats and then convert to String if valid. Else, return an error.

@manitgupta
Copy link
Member

Duplicate of #355.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants