Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Enable player login #37

Closed
dtest opened this issue Nov 15, 2022 · 2 comments · Fixed by #62
Closed

[Feature request] Enable player login #37

dtest opened this issue Nov 15, 2022 · 2 comments · Fixed by #62
Labels
enhancement New feature or request
Milestone

Comments

@dtest
Copy link
Collaborator

dtest commented Nov 15, 2022

Add endpoints for players to login and logout

New endpoints for authentication server and players service:

  • PUT /players/login: takes username and password as arguments. Returns playerUUID on success
  • PUT /players/logout: takes playerUUID as argument, returns 200 success, but no content (some concerns about authenticating access to this endpoint, but really no endpoint should be able to be hit without proper credentials)

This will update a 'logged_in' timestamp field in the players table, which will be set to null on logout.

Track login events in a separate table player_login_entries

@dtest dtest added the enhancement New feature or request label Nov 15, 2022
@dtest dtest added this to the v0.2.0 milestone Nov 15, 2022
@dtest
Copy link
Collaborator Author

dtest commented Nov 15, 2022

To do login, we need a way for generated players/bots to know the password.

Currently the load generators generate a random password. This logic can be changed to be a deterministic password, since these are not real players.

@dtest
Copy link
Collaborator Author

dtest commented Feb 24, 2023

The login tracking will be handled through issue #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant