Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase X "is ending" is not accurate #309

Closed
bruzzi opened this issue Jul 18, 2014 · 6 comments
Closed

Phase X "is ending" is not accurate #309

bruzzi opened this issue Jul 18, 2014 · 6 comments
Labels
enhancement

Comments

@bruzzi
Copy link

bruzzi commented Jul 18, 2014

We should say "has ended" as "in ending" implies it will be ending in the near future.
@skyhit
Copy link
Contributor

skyhit commented Jul 22, 2014

where did you see this?

@flytoj2ee
Copy link
Contributor

Any update?

@skyhit
Copy link
Contributor

skyhit commented Aug 5, 2014

no, leave to final fix. as I know this words is from backend. in the Phase Change popup

@flytoj2ee
Copy link
Contributor

In phase changed popup, it has text "The coding phase is ending for Test SRM - Test SRM Round."

Replace it with "has ended" in popup?

@skyhit
Copy link
Contributor

skyhit commented Aug 13, 2014

I think we should fix it in the backend. replace is just a temporary solution.

leave it for the bug fix.

@mdesiderio mdesiderio mentioned this issue Dec 13, 2014
Open
@mdesiderio
Copy link
Contributor

This issue was moved to appirio-tech/arena-web#249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@skyhit @bruzzi @mdesiderio @flytoj2ee