Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling/removing an ignore-rule may cause error #54

Closed
nlmarco opened this issue Aug 21, 2016 · 1 comment
Closed

Disabling/removing an ignore-rule may cause error #54

nlmarco opened this issue Aug 21, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@nlmarco
Copy link
Contributor

nlmarco commented Aug 21, 2016

java.lang.IllegalStateException: Just created directory, but corresponding RepoFile still does not exist after local sync: /home/mn/workspace/cloudstore.1/git/cloudstore/co.codewizards.cloudstore.test/target/repo/is46ijyt-nr9d8-local/1/dir1
at co.codewizards.cloudstore.local.transport.FileRepoTransport.mkDir(FileRepoTransport.java:604)
at co.codewizards.cloudstore.local.transport.FileRepoTransport.makeDirectory(FileRepoTransport.java:202)
at co.codewizards.cloudstore.core.repo.sync.RepoToRepoSync.makeDirectory(RepoToRepoSync.java:489)
at co.codewizards.cloudstore.core.repo.sync.RepoToRepoSync.syncDirectory(RepoToRepoSync.java:474)
at co.codewizards.cloudstore.core.repo.sync.RepoToRepoSync.sync(RepoToRepoSync.java:330)
at co.codewizards.cloudstore.core.repo.sync.RepoToRepoSync.sync(RepoToRepoSync.java:237)
at co.codewizards.cloudstore.core.repo.sync.RepoToRepoSync.sync(RepoToRepoSync.java:221)
at co.codewizards.cloudstore.core.repo.sync.RepoToRepoSync.syncDown(RepoToRepoSync.java:167)
...

@nlmarco
Copy link
Contributor Author

nlmarco commented Aug 21, 2016

Fixed by taking the ignore-rules only into account when performing an initial local-repo-sync. The ignore-rules must not be considered, when the sync is already running, because the code invoking LocalRepoSync.sync(...) later on, expects it to create a RepoFile instance.

If the files are ignored during the initial local-repo-sync, they are not processed, later, anyway. The only situation when this can happen, is during adding or removal of an ignore-rule. And IMHO it is the correct procedure to ignore files only initially, i.e. during the sync-start. But if they're not ignored then, they must be processed the entire way through.

@nlmarco nlmarco closed this as completed Aug 21, 2016
@nlmarco nlmarco added the bug label Aug 21, 2016
@nlmarco nlmarco added this to the 0.9.10 milestone Aug 21, 2016
@nlmarco nlmarco self-assigned this Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant