Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect files being copied (or moved/renamed) #5

Closed
nlmarco opened this issue Jan 30, 2014 · 0 comments
Closed

Detect files being copied (or moved/renamed) #5

nlmarco opened this issue Jan 30, 2014 · 0 comments
Assignees
Milestone

Comments

@nlmarco
Copy link
Contributor

nlmarco commented Jan 30, 2014

We should detect files being copied or moved/renamed and prevent copying them over the network.

Solution idea: We should store all of these as CopyModificaton in the database - including move/rename! Only when applying it to the sync destination, we should calculate a CopyModification+DeleteModification into one move.

The reason is that this makes handling all cases (moves AND copies) much easier and - most importantly - it makes it easier to handle remote repositories being connected to a sub-directory: For example, a "move" in the source might be a "delete" in the destination (if it is outside the connected directory).

Thus, we should persist ONLY Copy+Delete and derive all moves/renames from this.

@nlmarco nlmarco added this to the 0.9.1 milestone Feb 15, 2014
@nlmarco nlmarco closed this as completed Feb 15, 2014
nlmarco pushed a commit that referenced this issue Feb 17, 2014
Improved copy detection for whole directories being deleted.
@nlmarco nlmarco self-assigned this Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant