Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support Multiple custom images?? Consider increasing a field of CRD: image #124

Closed
nicole-lihui opened this issue Sep 2, 2022 · 2 comments · Fixed by #134
Closed
Labels
feature New feature

Comments

@nicole-lihui
Copy link

only found one method to define custom image config, and then no supported multiple custom images

helm install cloudtty-operator --version 0.3.0 daocloud/cloudtty --set jobTemplate.image.registry=</REGISTRY> --set jobTemplate.image.repository=</REPOSITORY> --set jobTemplate.image.tag=</TAG>

Suggestion: in CloudShell CRD add a field :image

spec:
  image: 
      registry: test.io
      repository:  custom-image
      tag: v1.0.0
@calvin0327
Copy link
Collaborator

@nicole-lihui thanks, do you think it's better if we set a field to represent image, like this:

spec:
  image: test.io/custom-image:v1.0.0

@nicole-lihui
Copy link
Author

nicole-lihui commented Sep 5, 2022

@nicole-lihui thanks, do you think it's better if we set a field to represent image, like this:

spec:
  image: test.io/custom-image:v1.0.0

This is a good idea @calvin0327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants