Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade cmd to cobra #62

Merged
merged 1 commit into from Sep 5, 2022
Merged

Conversation

calvin0327
Copy link
Collaborator

@calvin0327 calvin0327 commented Jul 1, 2022

Signed-off-by: calvin wen.chen@daocloud.io

/kind feature

upgrade our cmd to cobra.

  • add --verion --kubeconfig and more ElectionLease options.
  • replace log to klog

@calvin0327 calvin0327 force-pushed the upgrade-cobra-cmd branch 3 times, most recently from 6d07f0e to 5a4569f Compare July 3, 2022 14:22
@calvin0327 calvin0327 changed the title WIP: upgrade cmd to cobra upgrade cmd to cobra Jul 4, 2022
@panpan0000
Copy link
Member

Why do we need ElectionLease ?

@calvin0327
Copy link
Collaborator Author

Why do we need ElectionLease ?

If we are prepare to add mutils operator replicas to ensure high availability, wo need support elections feature.
We used to support it, just not very elegant.

@panpan0000
Copy link
Member

are those all necessary for cobra?
image

@calvin0327
Copy link
Collaborator Author

@panpan0000 We did not have a vendor directory before, but cloudtty has more and more features, so it is necessary to add a vendor directory

Signed-off-by: calvin <wen.chen@daocloud.io>
@panpan0000 panpan0000 merged commit b617f84 into cloudtty:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants