Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal:add a flag to support custom suffixes for IDL #135

Closed
Skyenought opened this issue Jul 14, 2022 · 2 comments
Closed

Proposal:add a flag to support custom suffixes for IDL #135

Skyenought opened this issue Jul 14, 2022 · 2 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.

Comments

@Skyenought
Copy link
Contributor

Skyenought commented Jul 14, 2022

Why did this proposal come up?

For reference, kitex supports custom suffix names, and Hertz makes it mandatory to determine IDL type by suffix.

I propose to unify the code style for the same cloudwego subproject.

Describe alternatives you've considered

From a user experience point of view, the type is determined by the suffix by default, but the option to customize the suffix is left to the user.

For Kitex, add the default suffix determination function, but also support custom suffixes.

Hertz adds the function of custom suffixes.

为什么会出现这个提案 ?

参考 kitex 支持自定义后缀名,Hertz 为强规定通过后缀判断 IDL 类型。
我提议同属于 cloudwego 的子项目,最好统一代码风格。

描述你想要的解决方案

从用户体验的角度来看, 默认通过后缀判断类型,但是还是要留给用户去自定义后缀的选项。

即给 kitex 增加默认后缀判断功能,但同时支持自定义后缀。

Hertz 增加自定义后缀的功能。

@welkeyever welkeyever added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jul 18, 2022
@L2ncE
Copy link
Member

L2ncE commented Sep 15, 2022

Support to unify the style of kitex and hertz

@Skyenought
Copy link
Contributor Author

kitex 已经支持了后缀猜测
cloudwego/kitex#590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Development

No branches or pull requests

4 participants