Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hlog lacks examples and unit tests #293

Closed
L2ncE opened this issue Oct 13, 2022 · 4 comments · Fixed by cloudwego/hertz-examples#42 or cloudwego/cloudwego.github.io#393
Closed

hlog lacks examples and unit tests #293

L2ncE opened this issue Oct 13, 2022 · 4 comments · Fixed by cloudwego/hertz-examples#42 or cloudwego/cloudwego.github.io#393
Assignees
@L2ncE
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@L2ncE
Copy link
Member

L2ncE commented Oct 13, 2022

Is your feature request related to a problem? Please describe.

I see a lack of samples and unit tests for the use of hlog

Describe the solution you'd like

add examples and unit tests
@li-jin-gou
Copy link
Member

Thanks for reporting! Are you interested in submitting a pr to solve it?
It's OK if it is not so, I'll put it into TODOs.

@L2ncE
Copy link
Member Author

L2ncE commented Oct 13, 2022

Thanks for reporting! Are you interested in submitting a pr to solve it? It's OK if it is not so, I'll put it into TODOs.

I'd like to try

@L2ncE L2ncE mentioned this issue Oct 14, 2022
Merged
@li-jin-gou li-jin-gou added good first issue Good for newcomers enhancement New feature or request labels Oct 14, 2022
@li-jin-gou
Copy link
Member

@L2ncE We should also improve the logging documentation to let users know that we support zap log.

@L2ncE
Copy link
Member Author

L2ncE commented Oct 14, 2022

@L2ncE We should also improve the logging documentation to let users know that we support zap log.

got it

This was referenced Oct 14, 2022
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@L2ncE L2ncE

Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add hlog example L2ncE/hertz-examples
docs: improve log and log extension docs
2 participants
@L2ncE @li-jin-gou