Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal(feat): support multipart/byteranges #93

Open
byene0923 opened this issue Jun 22, 2022 · 1 comment
Open

Proposal(feat): support multipart/byteranges #93

byene0923 opened this issue Jun 22, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@byene0923
Copy link
Member

Is your feature request related to a problem? Please describe.
I see hertz only support Single part ranges, i think it's better to support Multipart ranges

Describe the solution you'd like

Describe alternatives you've considered

Additional context
golang std http support it
https://github.com/golang/go/blob/be0b2a393a5a7297a3c8f42ca7d5ad3e4b15dcbe/src/net/http/fs.go#L870

@Duslia Duslia added the enhancement New feature or request label Jun 23, 2022
@welkeyever welkeyever changed the title feat: support multipart/byteranges Proposal(feat): support multipart/byteranges Jul 6, 2022
@byene0923
Copy link
Member Author

byene0923 commented Jul 6, 2022

After reading how hertz handle single part , i found it's quite different from go std http。
the core difference is go std http read the bytes once but hertz read the bytes may in serval times。 because hertz use copyZeroAlloc,this will make support Multipart ranges complicated
i think how hertz support multipart/byteranges needs reviewing, i‘m writing the detail now。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants