Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The behavior of retry policy is not consistent. #1042

Closed
whalecold opened this issue Jul 27, 2023 · 4 comments
Closed

The behavior of retry policy is not consistent. #1042

whalecold opened this issue Jul 27, 2023 · 4 comments

Comments

@whalecold
Copy link
Member

Describe the bug

Kitex has the ability to configure the retry policy dynamically, but the semantics is not consistent in these conditions:

  • initialize a disabled policy will ignore it, the policy for the method may fall back to wildcard.
  • update an enabled policy to disable, the retry will be disabled and not fall back to wildcard

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

the behavior of these conditions above should keep consistent.

Screenshots

If applicable, add screenshots to help explain your problem.

Kitex version:

Please provide the version of Kitex you are using.

Environment:

The output of go env.

Additional context

Add any other context about the problem here.

@YangruiEmma
Copy link
Member

You are right, maybe it is a problem, for the second one, we just update the status but not remove the method configuration, so it won't do fallback to wildcard. From your scenario, which one do you think it is reasonable?

@whalecold
Copy link
Member Author

I think no fallback makes sense as it is specified to disable the policy.

@YangruiEmma
Copy link
Member

It will be marked as todo

@whalecold
Copy link
Member Author

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants