Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal: Allow custom registry to get the actual address for registering #1329

Closed
felix021 opened this issue Apr 17, 2024 · 3 comments · Fixed by #1333
Closed

Feature Proposal: Allow custom registry to get the actual address for registering #1329

felix021 opened this issue Apr 17, 2024 · 3 comments · Fixed by #1333
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@felix021
Copy link
Contributor

felix021 commented Apr 17, 2024

Currently custom registry (specified by server.WithRegistry(r)) always get the listen address, even if a registry.Info with Addr set is specified by server.WithRegistryInfo.

But there are cases that the listen address is not accessible from the client. For example, the client might need to use the public IP addresss, which is usually different with the listen address.

registry-etcd solved this with the workaround of manually specifying the public address when initializing the registry, which does not applicable to other registries (for now).

In this proposal, we suggest adding another option to the registry.Info instructing Kitex server to pass the real address to custom registries, which solves this issue for all existing implementations like registry-nacos.

If you are interested in implementing this feature, please kindly prepare a detailed tech plan and reply with your lark id for us.

@felix021 felix021 added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 17, 2024
@XiaoYi-byte
Copy link
Contributor

I want to try it

@felix021
Copy link
Contributor Author

I want to try it

Please prepare a tech plan first.

@felix021
Copy link
Contributor Author

felix021 commented May 6, 2024

Should be released with the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Development

Successfully merging a pull request may close this issue.

2 participants