Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor outputting #21

Closed
wants to merge 13 commits into from
Closed

feat: refactor outputting #21

wants to merge 13 commits into from

Conversation

joway
Copy link
Member

@joway joway commented Jul 20, 2021 •
edited

  • Close connection gracefully:
    • conn used by client: closeCallback should wait for Flush && Outputs finished.
    • conn used by server: closeCallback should wait for onRequest processed if is processing.
  • Flush should do the syscall by itself and poller only promise to wake up writer trigger.

@joway joway requested a review from Hchenn July 20, 2021 10:18
@joway joway changed the title feat: using outputting lock to replace writing/inputbuffer/outputbuffer lock feat: refactor outputting Jul 21, 2021
@joway joway force-pushed the feat/rm-output-lock branch 2 times, most recently from 1637112 to 958f692 Compare July 21, 2021 10:43
Hchenn
Hchenn reviewed Jul 21, 2021
View reviewed changes
connection_reactor.go Outdated Show resolved Hide resolved
poll_race_linux.go Outdated Show resolved Hide resolved
connection_impl.go Outdated Show resolved Hide resolved
connection_onevent.go Outdated Show resolved Hide resolved
connection_onevent.go
defer c.unlock(processing)

// close callback should only been executed once
if !c.stop(outputting) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

调用位置需要调整一下，线下讨论

Base automatically changed from develop to main September 16, 2021 06:41
@joway joway changed the base branch from main to develop September 16, 2021 09:48
@joway joway closed this Sep 22, 2021
@joway joway deleted the feat/rm-output-lock branch September 22, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hchenn Hchenn Hchenn left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joway @Hchenn