Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerPort does not map to telemetry port value in deployment template #3

Closed
joan-s-molas opened this issue May 2, 2019 · 2 comments
Closed

containerPort does not map to telemetry port value in deployment template #3

joan-s-molas opened this issue May 2, 2019 · 2 comments

Comments

@joan-s-molas
Copy link
Contributor

joan-s-molas commented May 2, 2019 •
edited
Loading

In the deployment template, the http containerPort does not match the telemetry port in the value file - it's just statically set to 80, which causes the probes to endlessly fail:

            - name: http
              containerPort: 80
              protocol: TCP

I think it should be

            - name: http
              containerPort: {{ .Values.telemetry.port }}
              protocol: TCP
@joan-s-molas joan-s-molas mentioned this issue May 2, 2019
Merged
@weeco
Copy link
Member

weeco commented May 2, 2019

Fixed by #4 but not yet packaged.

Thanks for submitting the issue + PR 🔥

@weeco
Copy link
Member

weeco commented May 4, 2019

Packageed and pushed

@weeco weeco closed this as completed May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weeco @joan-s-molas