Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify bitness of SquirrelAware apps during install #35

Closed
caesay opened this issue Jan 27, 2022 · 0 comments
Closed

Verify bitness of SquirrelAware apps during install #35

caesay opened this issue Jan 27, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@caesay
Copy link
Member

caesay commented Jan 27, 2022

It's currently possible for x86 squirrel, running on x86 windows, to install an x64 program. Of course, this program will fail to run hooks, fail to create shortcuts, and be entirely useless.

It would be better if Setup.exe verified the bitness of Squirrel Aware apps, and refused to install if the binaries are unsupported on the current operating system.

It would probably make sense to analyse the binaries ahead of time while building releases and storing metadata in the package somewhere, so the executables do not need to be extracted during install if they are incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant