Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed hearthbeat bug #429

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Fixed hearthbeat bug #429

merged 4 commits into from
Nov 13, 2023

Conversation

lmarini
Copy link
Member

@lmarini lmarini commented Oct 27, 2023

where if the owner was not set in extractors_info.json clowder would throw and error and the extractor would not get registered.

@lmarini
Fixed hearthbeat bug where if the owner was not set in extractors_inf…
8661eb1 
…o.json clowder would

throw and error and the extractor would not get registered.
@lmarini lmarini linked an issue Oct 27, 2023 that may be closed by this pull request
Extractor not coming back after deleting #428
Open
@lmarini
Copy link
Member Author

lmarini commented Oct 27, 2023

@max-zilla can you test a private extractor that includes an owner in extractor_info.json. Thank you.

@lmarini
Updated version to 1.22.1
7d8e2ed
@lmarini
Merge branch 'master' into 428-extractor-not-coming-back-after-deleting
d404048 
# Conflicts:
#	CHANGELOG.md
#	doc/src/sphinx/conf.py
#	project/Build.scala
#	public/swagger.yml
#	version.sh
@lmarini lmarini changed the base branch from develop to master October 27, 2023 19:55
@lmarini lmarini marked this pull request as ready for review October 27, 2023 19:55
robkooper
robkooper reviewed Oct 27, 2023
View reviewed changes
version.sh Show resolved Hide resolved
max-zilla
max-zilla approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@max-zilla max-zilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all seems to work as expected.

@minump
Copy link

minump commented Nov 10, 2023

I was able to test this as well. Ran ghcr.io/clowder-framework/clowder:PR-429, deleted a private extractor from UI (http://localhost:8000/extractors/pdfminer-extractor) . Saw that the extractor came back on (name popped up in the list of extractors) after heartbeat time.

Tested. works fine. approving.

@lmarini
Copy link
Member Author

lmarini commented Nov 13, 2023

I was able to test this as well. Ran ghcr.io/clowder-framework/clowder:PR-429, deleted a private extractor from UI (http://localhost:8000/extractors/pdfminer-extractor) . Saw that the extractor came back on (name popped up in the list of extractors) after heartbeat time.

Tested. works fine. approving.

Thanks! Next time feel free to add yourself to list of reviewers.

@lmarini lmarini merged commit f28c203 into master Nov 13, 2023
10 checks passed
@lmarini lmarini deleted the 428-extractor-not-coming-back-after-deleting branch November 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robkooper robkooper robkooper left review comments

@max-zilla max-zilla max-zilla approved these changes

@longshuicy longshuicy Awaiting requested review from longshuicy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extractor not coming back after deleting
4 participants
@lmarini @minump @robkooper @max-zilla